netdev - Re: [PATCH net] net: Disable NETIF_F_HW_TLS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210119160017.000eaafd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 19 Jan 2021 16:00:17 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tariq Toukan <tariqt@...dia.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Boris Pismenny <borisp@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <ttoukan.linux@...il.com>,
        Moshe Shemesh <moshe@...dia.com>
Subject: Re: [PATCH net] net: Disable NETIF_F_HW_TLS_RX when RXCSUM is
 disabled

On Sun, 17 Jan 2021 17:15:38 +0200 Tariq Toukan wrote:
> With NETIF_F_HW_TLS_RX packets are decrypted in HW. This cannot be
> logically done when RXCSUM offload is off.
> 
> Fixes: 14136564c8ee ("net: Add TLS RX offload feature")
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>
> Reviewed-by: Boris Pismenny <borisp@...dia.com>

Applied, but it's not 100% equivalent to Tx. For Rx we _can_
efficiently fall back to SW.