netdev - Re: [PATCH v2 net-next] net: fix GSO for SG-enabled devices.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210119184349.493981e7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 19 Jan 2021 18:43:49 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Xin Long <lucien.xin@...il.com>, Paolo Abeni <pabeni@...hat.com>
Cc:     network dev <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Alexander Duyck <alexanderduyck@...com>
Subject: Re: [PATCH v2 net-next] net: fix GSO for SG-enabled devices.

On Wed, 20 Jan 2021 10:17:44 +0800 Xin Long wrote:
> On Wed, Jan 20, 2021 at 12:57 AM Paolo Abeni <pabeni@...hat.com> wrote:
> >
> > The commit dbd50f238dec ("net: move the hsize check to the else
> > block in skb_segment") introduced a data corruption for devices
> > supporting scatter-gather.
> >
> > The problem boils down to signed/unsigned comparison given
> > unexpected results: if signed 'hsize' is negative, it will be
> > considered greater than a positive 'len', which is unsigned.
> >
> > This commit addresses resorting to the old checks order, so that
> > 'hsize' never has a negative value when compared with 'len'.
> >
> > v1 -> v2:
> >  - reorder hsize checks instead of explicit cast (Alex)
> >
> > Bisected-by: Matthieu Baerts <matthieu.baerts@...sares.net>
> > Fixes: dbd50f238dec ("net: move the hsize check to the else block in skb_segment")
> > Signed-off-by: Paolo Abeni <pabeni@...hat.com>  
> Reviewed-by: Xin Long <lucien.xin@...il.com>

I'm hitting this as well, so applied, thanks!

> > ---
> Reviewed-by: Xin Long <lucien.xin@...il.com>

One review tag is enough ;) apparently patchwork doesn't know to dedup
them :S