netdev - Re: [PATCH net] net: dsa: b53: fix an off by one in checking "vlan->vid"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210119193548.515ab674@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 19 Jan 2021 19:35:48 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: b53: fix an off by one in checking
 "vlan->vid"

On Tue, 19 Jan 2021 09:14:03 -0800 Florian Fainelli wrote:
> On 1/19/2021 6:48 AM, Dan Carpenter wrote:
> > The > comparison should be >= to prevent accessing one element beyond
> > the end of the dev->vlans[] array in the caller function, b53_vlan_add().
> > The "dev->vlans" array is allocated in the b53_switch_init() function
> > and it has "dev->num_vlans" elements.
> > 
> > Fixes: a2482d2ce349 ("net: dsa: b53: Plug in VLAN support")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>  
> 
> Acked-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks!