netdev - Re: [PATCH v1] can: mcp251xfd: replace sizeof(u32) with val

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210121085104.kp5qkllzyfu6ybtj@hardanger.blackshift.org>
Date:   Thu, 21 Jan 2021 09:51:04 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Su Yanjun <suyanjun218@...il.com>
Cc:     manivannan.sadhasivam@...aro.org, thomas.kopp@...rochip.com,
        wg@...ndegger.com, davem@...emloft.net, kuba@...nel.org,
        lgirdwood@...il.com, broonie@...nel.org, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] can: mcp251xfd: replace sizeof(u32) with val_bytes in
 regmap

On Thu, Jan 21, 2021 at 04:33:13PM +0800, Su Yanjun wrote:
> No functional effect.
> 
> Signed-off-by: Su Yanjun <suyanjun218@...il.com>

Fails to build from source:

  CC [M]  drivers/net/can/spi/mcp251xfd/mcp251xfd-core.o
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: In function ‘mcp251xfd_get_val_bytes’:
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c:187:22: error: invalid use of undefined type ‘struct regmap’
  187 |  return priv->map_reg->format.val_bytes;
      |                      ^~
rivers/net/can/spi/mcp251xfd/mcp251xfd-core.c:188:1: error: control reaches end of non-void function [-Werror=return-type]
  188 | }
      | ^
cc1: some warnings being treated as errors

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)