netdev - Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

Open Source and information security mailing list archives

Message-ID: <20210121102753.GO1551@shell.armlinux.org.uk>
Date:   Thu, 21 Jan 2021 10:27:54 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Marc Zyngier <maz@...nel.org>, linux-kernel@...r.kernel.org,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Dinh Nguyen <dinguyen@...nel.org>,
        Brandon Streiff <brandon.streiff@...com>,
        Olof Johansson <olof@...om.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Vladimir Oltean <olteanv@...il.com>,
        David Miller <davem@...emloft.net>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote:
> The mvpp2 is an Ethernet driver, and it implements MAC style time
> stamping of PTP frames.  It has no need of the expensive option to
> enable PHY time stamping.  Remove the incorrect dependency.
> 
> Signed-off-by: Richard Cochran <richardcochran@...il.com>
> Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")

NAK.

> ---
>  drivers/net/ethernet/marvell/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig
> index 41815b609569..7fe15a3286f4 100644
> --- a/drivers/net/ethernet/marvell/Kconfig
> +++ b/drivers/net/ethernet/marvell/Kconfig
> @@ -94,7 +94,6 @@ config MVPP2
>  
>  config MVPP2_PTP
>  	bool "Marvell Armada 8K Enable PTP support"
> -	depends on NETWORK_PHY_TIMESTAMPING
>  	depends on (PTP_1588_CLOCK = y && MVPP2 = y) || \
>  		   (PTP_1588_CLOCK && MVPP2 = m)
>  
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives