netdev - Re: [PATCH v2 net-next 1/1] net: dsa: hellcreek: Add TAPRIO offloading support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210120165039.2867de26@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 20 Jan 2021 16:50:39 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Kurt Kanzenbach <kurt@...utronix.de>
Cc:     Vladimir Oltean <olteanv@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 1/1] net: dsa: hellcreek: Add TAPRIO
 offloading support

On Wed, 20 Jan 2021 08:18:15 +0100 Kurt Kanzenbach wrote:
> >> +	/* Schedule periodic schedule check */
> >> +	schedule_delayed_work(&hellcreek_port->schedule_work,
> >> +			      HELLCREEK_SCHEDULE_PERIOD);  
> >
> > Why schedule this work every 2 seconds rather than scheduling it
> > $start_time - 8 sec + epsilon?  
> 
> The two seconds are taken from the programming guide. That's why I used
> it.
> 
> The PTP frequency starts to matter for large deltas. In theory the
> rescheduling period can be increased [1]. Should I adjust it? 

I see, makes sense. You can leave it as is, please just add a comment
next to the definition saying that the exact value is not important we
just want it to be low enough to no suffer from clock freq error.