netdev - Re: [PATCH net 1/4] net: dsa: mv88e6xxx: Remove bogus Kconfig dependency.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f83347f-5e8e-815a-9692-1f1bb2994fc0@ni.com>
Date:   Thu, 21 Jan 2021 13:59:02 -0600
From:   Brandon Streiff <brandon.streiff@...com>
To:     Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Dinh Nguyen <dinguyen@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Marc Zyngier <maz@...nel.org>, Olof Johansson <olof@...om.net>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 1/4] net: dsa: mv88e6xxx: Remove bogus Kconfig
 dependency.

On 1/20/2021 10:06 PM, Richard Cochran wrote:
> The mv88e6xxx is a DSA driver, and it implements DSA style time
> stamping of PTP frames.  It has no need of the expensive option to
> enable PHY time stamping.  Remove the bogus dependency.
> 
> Signed-off-by: Richard Cochran <richardcochran@...il.com>
> Fixes: 2fa8d3af4bad ("net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock")
Ah, I must have thought I needed skb_defer_rx_timestamp in mv88e6xxx,
but instead DSA gained its own timestamp path so mv88e6xxx turned out
to not need that at all, and I never went back and dropped the Kconfig
dependency. Whoops. Yup, I don't think we don't need it here.

Acked-by: Brandon Streiff <brandon.streiff@...com>