netdev - rpc_xprt_debugfs_register() - atomic_inc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <06c8f6ff-f821-e909-d40c-9de98657729f@linuxfoundation.org>
Date:   Wed, 20 Jan 2021 16:52:34 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Anna.Schumaker@...app.com, trond.myklebust@...merspace.com
Cc:     "J. Bruce Fields" <bfields@...ldses.org>, chuck.lever@...cle.com,
        "David S. Miller" <davem@...emloft.net>, kuba@...nel.org,
        linux-nfs@...r.kernel.org, Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: rpc_xprt_debugfs_register() - atomic_inc_return() usage

Hi Anna and Trond,

I came across the following while reviewing atomic_inc_return() usages
that cast return value to unsigned

rpc_xprt_debugfs_register()'s atomic_inc_return() usage looks a bit odd.

- cur_id isn't initialized
- id = (unsigned int)atomic_inc_return(&cur_id);

Please note that id is int. Is it expected that cur_id could overflow?
Is there a maximum limit for this value?

thanks,
-- Shuah