netdev - Re: [PATCH] Revert "octeontx2-pf: Use the napi_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210120211320.61c612ee@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 20 Jan 2021 21:13:20 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Kevin Hao <haokexin@...il.com>
Cc:     sundeep.lkml@...il.com, davem@...emloft.net,
        netdev@...r.kernel.org, gakula@...vell.com, hkelam@...vell.com,
        Subbaraya Sundeep <sbhatta@...vell.com>,
        Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH] Revert "octeontx2-pf: Use the napi_alloc_frag() to
 alloc the pool buffers"

On Thu, 21 Jan 2021 13:09:10 +0800 Kevin Hao wrote:
> On Wed, Jan 20, 2021 at 08:59:14PM -0800, Jakub Kicinski wrote:
> > On Thu, 21 Jan 2021 12:20:35 +0800 Kevin Hao wrote:  
> > > Hmm, why not?
> > >   buf = napi_alloc_frag(pool->rbsize + 128);
> > >   buf = PTR_ALIGN(buf, 128);  
> > 
> > I'd keep the aligning in the driver until there are more users
> > needing this but yes, I agree, aligning the page frag buffers 
> > seems like a much better fix.  
> 
> It seems that the DPAA2 driver also need this (drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c):
> 	/* Prepare the HW SGT structure */
> 	sgt_buf_size = priv->tx_data_offset +
> 		       sizeof(struct dpaa2_sg_entry) *  num_dma_bufs;
> 	sgt_buf = napi_alloc_frag(sgt_buf_size + DPAA2_ETH_TX_BUF_ALIGN);
> 	if (unlikely(!sgt_buf)) {
> 		err = -ENOMEM;
> 		goto sgt_buf_alloc_failed;
> 	}
> 	sgt_buf = PTR_ALIGN(sgt_buf, DPAA2_ETH_TX_BUF_ALIGN);

We can fix them both up as a follow up in net-next, then?

Let's keep the patch small and local for the fix.