netdev - Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YAtebdG1Q0dxxkdC@lunn.ch>
Date:   Sat, 23 Jan 2021 00:23:25 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Sergej Bauer <sbauer@...ckbox.su>
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Bryan Whitehead <bryan.whitehead@...rochip.com>,
        UNGLinuxDriver@...rochip.com,
        Simon Horman <simon.horman@...ronome.com>,
        Mark Einon <mark.einon@...il.com>,
        Madalin Bucur <madalin.bucur@....nxp.com>,
        Arnd Bergmann <arnd@...db.de>,
        Masahiro Yamada <masahiroy@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

> > > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct
> > > lan743x_adapter *adapter)> 
> > >  	struct net_device *netdev = adapter->netdev;
> > >  	
> > >  	phy_stop(netdev->phydev);
> > > 
> > > -	phy_disconnect(netdev->phydev);
> > > -	netdev->phydev = NULL;
> > > +	if (phy_is_pseudo_fixed_link(netdev->phydev))
> > > +		lan743x_virtual_phy_disconnect(netdev->phydev);
> > > +	else
> > > +		phy_disconnect(netdev->phydev);
> > 
> > phy_disconnect() should work. You might want to call

There are drivers which call phy_disconnect() on a fixed_link. e.g.

https://elixir.bootlin.com/linux/v5.11-rc4/source/drivers/net/usb/lan78xx.c#L3555.

It could be your missing call to fixed_phy_unregister() is leaving
behind bad state.

> It was to make ethtool show full set of supported speeds and MII only in
> supported ports (without TP and the no any ports in the bare card).

But fixed link does not support the full set of speed. It is fixed. It
supports only one speed it is configured with.  And by setting it
wrongly, you are going to allow the user to do odd things, like use
ethtool force the link speed to a speed which is not actually
supported.

    Andrew