netdev - Re: [PATCH net-next] vmxnet3: Remove buf_info from device accessible structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <888F37FB-B8BD-43D8-9E75-4F1CE9D4FAC7@vmware.com>
Date:   Fri, 22 Jan 2021 08:24:59 +0000
From:   Ronak Doshi <doshir@...are.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Petr Vandrovec <petr@...are.com>,
        Pv-drivers <Pv-drivers@...are.com>,
        "David S. Miller" <davem@...emloft.net>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] vmxnet3: Remove buf_info from device accessible
 structures


On 1/21/21, 5:07 PM, "Jakub Kicinski" <kuba@...nel.org> wrote:
>  On Tue, 19 Jan 2021 18:19:40 -0800 Ronak Doshi wrote:
>  > From: Petr Vandrovec <petr@...are.com>
>  > 
>  > vmxnet3: Remove buf_info from device accessible structures
>
>    Something happened to the posting, looks like the subject is listed
>   twice?
It got sent twice. Please ignore.

>  > -	if (!tq->buf_info)
>  > +	tq->buf_info = kmalloc_array_node(tq->tx_ring.size, sizeof(tq->buf_info[0]),
>  > +					  GFP_KERNEL | __GFP_ZERO,
>  > +					  dev_to_node(&adapter->pdev->dev));
>
>   kcalloc_node()
Sure, will use this callback.

>  > +	if (!tq->buf_info) {
>  > +		netdev_err(adapter->netdev, "failed to allocate tx buffer info\n")
>
> Please drop the message, OOM splat will be visible enough. checkpatch
> usually points this out

Okay, will drop it. Checkpatch did not complain about the error message though.

Thanks,
Ronak