netdev - Re: pull-request: mac80211 2021-01-18.2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77c606d4-a78a-1fa3-5937-b270c3d0bbd3@redhat.com>
Date:   Sat, 23 Jan 2021 22:31:41 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Johannes Berg <johannes@...solutions.net>, netdev@...r.kernel.org
Cc:     linux-wireless@...r.kernel.org
Subject: Re: pull-request: mac80211 2021-01-18.2



On 1/18/21 9:47 PM, Johannes Berg wrote:
> Hi,
> 
> New try, dropped the 160 MHz CSA patch for now that has the sparse
> issue since people are waiting for the kernel-doc fixes.
> 
> Please pull and let me know if there's any problem.
> 
> Thanks,
> johannes
> 
> 
> 
> The following changes since commit 220efcf9caf755bdf92892afd37484cb6859e0d2:
> 
>   Merge tag 'mlx5-fixes-2021-01-07' of git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux (2021-01-07 19:13:30 -0800)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git tags/mac80211-for-net-2021-01-18.2
> 
> for you to fetch changes up to c13cf5c159660451c8fbdc37efb998b198e1d305:
> 
>   mac80211: check if atf has been disabled in __ieee80211_schedule_txq (2021-01-14 22:27:38 +0100)
> 
> ----------------------------------------------------------------
> Various fixes:
>  * kernel-doc parsing fixes
>  * incorrect debugfs string checks
>  * locking fix in regulatory
>  * some encryption-related fixes
> 
> ----------------------------------------------------------------
> Felix Fietkau (3):
>       mac80211: fix fast-rx encryption check
>       mac80211: fix encryption key selection for 802.3 xmit
>       mac80211: do not drop tx nulldata packets on encrypted links
> 
> Ilan Peer (1):
>       cfg80211: Save the regulatory domain with a lock

So I'm afraid that I have some bad news about this patch, it fixes
the RCU warning which I reported:

https://lore.kernel.org/linux-wireless/20210104170713.66956-1-hdegoede@redhat.com/

But it introduces a deadlock. See:

https://lore.kernel.org/linux-wireless/d839ab62-e4bc-56f0-d861-f172bf19c4b3@redhat.com/

for details. Note we really should fix this new deadlock before 5.11
is released. This is worse then the RCU warning which this patch fixes.

Regards,

Hans



> 
> Johannes Berg (1):
>       cfg80211/mac80211: fix kernel-doc for SAR APIs
> 
> Lorenzo Bianconi (1):
>       mac80211: check if atf has been disabled in __ieee80211_schedule_txq
> 
> Mauro Carvalho Chehab (1):
>       cfg80211: fix a kerneldoc markup
> 
> Shayne Chen (1):
>       mac80211: fix incorrect strlen of .write in debugfs
> 
>  include/net/cfg80211.h |  5 ++++-
>  include/net/mac80211.h |  1 +
>  net/mac80211/debugfs.c | 44 ++++++++++++++++++++------------------------
>  net/mac80211/rx.c      |  2 ++
>  net/mac80211/tx.c      | 31 +++++++++++++++++--------------
>  net/wireless/reg.c     | 11 ++++++++++-
>  6 files changed, 54 insertions(+), 40 deletions(-)
> 
>