netdev - Re: [PATCH v2 RFC net-next 08/18] net: mvpp2: add FCA periodic timer configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210124121443.GU1551@shell.armlinux.org.uk>
Date:   Sun, 24 Jan 2021 12:14:43 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     stefanc@...vell.com
Cc:     netdev@...r.kernel.org, thomas.petazzoni@...tlin.com,
        davem@...emloft.net, nadavh@...vell.com, ymarkman@...vell.com,
        linux-kernel@...r.kernel.org, kuba@...nel.org, mw@...ihalf.com,
        andrew@...n.ch, atenart@...nel.org
Subject: Re: [PATCH v2 RFC net-next 08/18] net: mvpp2: add FCA periodic timer
 configurations

On Sun, Jan 24, 2021 at 01:43:57PM +0200, stefanc@...vell.com wrote:
> +/* Set Flow Control timer x140 faster than pause quanta to ensure that link
> + * partner won't send taffic if port in XOFF mode.

Can you explain more why 140 times faster is desirable here? Why 140
times and not, say, 10 times faster? Where does this figure come from,
and what is the reasoning? Is there a switch that requires it?

Also, spelling "traffic".

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!