netdev - Re: [PATCH] dsa: mv88e6xxx: Make global2 support mandatory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <234a7b27-da8b-b224-26f7-d8ff1c03b10a@gmail.com>
Date:   Sat, 23 Jan 2021 19:24:34 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>
Cc:     netdev <netdev@...r.kernel.org>,
        Vladimir Oltean <vladimir.oltean@....com>,
        tobias@...dekranz.com
Subject: Re: [PATCH] dsa: mv88e6xxx: Make global2 support mandatory



On 1/23/2021 7:06 PM, Jakub Kicinski wrote:
> On Sat, 23 Jan 2021 21:51:48 +0100 Andrew Lunn wrote:
>> Early generations of the mv88e6xxx did not have the global 2
>> registers. In order to keep the driver slim, it was decided to make
>> the code for these registers optional. Over time, more generations of
>> switches have been added, always supporting global 2 and adding more
>> and more registers. No effort has been made to keep these additional
>> registers also optional to slim the driver down when used for older
>> generations. Optional global 2 now just gives additional development
>> and maintenance burden for no real gain.
>>
>> Make global 2 support always compiled in.
>>
>> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> 
> FWIW doesn't seem to apply to net-next.

Andrew, when you resubmit, can you make the subject be: net: dsa: ... to
be consistent with prior changes? Thanks!
-- 
Florian