netdev - Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and implement private channel OPs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210125125241.495d8d82@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 25 Jan 2021 12:52:41 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jason Gunthorpe <jgg@...dia.com>
Cc:     Leon Romanovsky <leon@...nel.org>,
        Shiraz Saleem <shiraz.saleem@...el.com>, <dledford@...hat.com>,
        <davem@...emloft.net>, <linux-rdma@...r.kernel.org>,
        <gregkh@...uxfoundation.org>, <netdev@...r.kernel.org>,
        <david.m.ertman@...el.com>, <anthony.l.nguyen@...el.com>,
        Mustafa Ismail <mustafa.ismail@...el.com>
Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and
 implement private channel OPs

On Mon, 25 Jan 2021 09:28:34 -0400 Jason Gunthorpe wrote:
> On Sun, Jan 24, 2021 at 03:45:51PM +0200, Leon Romanovsky wrote:
> > On Fri, Jan 22, 2021 at 05:48:12PM -0600, Shiraz Saleem wrote:  
> > > From: Mustafa Ismail <mustafa.ismail@...el.com>
> > >
> > > Register irdma as an auxiliary driver which can attach to auxiliary RDMA
> > > devices from Intel PCI netdev drivers i40e and ice. Implement the private
> > > channel ops, add basic devlink support in the driver and register net
> > > notifiers.  
> > 
> > Devlink part in "the RDMA client" is interesting thing.
> > 
> > The idea behind auxiliary bus was that PCI logic will stay at one place
> > and devlink considered as the tool to manage that.  
> 
> Yes, this doesn't seem right, I don't think these auxiliary bus
> objects should have devlink instances

+1