netdev - Re: [RFC v3 net-next] net: core: devlink: add 'dropped' stats field for DROP trap action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210125132317.418a4e35@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 25 Jan 2021 13:23:17 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Oleksandr Mazur <oleksandr.mazur@...ision.eu>
Cc:     netdev@...r.kernel.org, jiri@...dia.com, davem@...emloft.net,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC v3 net-next] net: core: devlink: add 'dropped' stats field
 for DROP trap action

On Mon, 25 Jan 2021 14:38:56 +0200 Oleksandr Mazur wrote:
> +	if (trap_item->action == DEVLINK_TRAP_ACTION_DROP &&
> +	    devlink->ops->trap_drop_counter_get) {
> +		err = devlink->ops->trap_drop_counter_get(devlink,
> +							  trap_item->trap,
> +							  &drops);
> +		if (err)
> +			return err;
> +	}

Why only report this counter when action is set to drop?

Thinking about it again - if the action can be changed wouldn't it 
be best for the user to actually get a "HW condition hit" counter,
which would increment regardless of SW config (incl. policers)?

Otherwise if admin logs onto the box and temporarily enables a trap 
for debug this count would disappear.