netdev - Re: [PATCH net-next] tg3: improve PCI VPD access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Jan 2021 15:24:57 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michael Chan <michael.chan@...adcom.com>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Siva Reddy Kallam <siva.kallam@...adcom.com>,
        Prashant Sreedharan <prashant@...adcom.com>,
        Michael Chan <mchan@...adcom.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] tg3: improve PCI VPD access

On Mon, 25 Jan 2021 14:09:16 -0800 Michael Chan wrote:
> On Fri, Jan 22, 2021 at 4:08 AM Heiner Kallweit <hkallweit1@...il.com> wrote:
> >
> > When working on the PCI VPD code I also tested with a Broadcom BCM95719
> > card. tg3 uses internal NVRAM access with this card, so I forced it to
> > PCI VPD mode for testing. PCI VPD access fails
> > (i + PCI_VPD_LRDT_TAG_SIZE + j > len) because only TG3_NVM_VPD_LEN (256)
> > bytes are read, but PCI VPD has 400 bytes on this card.
> >
> > So add a constant TG3_NVM_PCI_VPD_MAX_LEN that defines the maximum
> > PCI VPD size. The actual VPD size is returned by pci_read_vpd().
> > In addition it's not worth looping over pci_read_vpd(). If we miss the
> > 125ms timeout per VPD dword read then definitely something is wrong,
> > and if the tg3 module loading is killed then there's also not much
> > benefit in retrying the VPD read.
> >
> > Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>  
> 
> Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Applied, thank you!