netdev - Re: pull-request: mac80211 2021-01-18.2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <666b3449fe33d34123255cc69da3aa46fc276dcb.camel@sipsolutions.net>
Date:   Mon, 25 Jan 2021 10:47:21 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Hans de Goede <hdegoede@...hat.com>,
        "Peer, Ilan" <ilan.peer@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "Coelho, Luciano" <luciano.coelho@...el.com>
Subject: Re: pull-request: mac80211 2021-01-18.2

Hi,

Sorry, apparently we have two threads.

> Great, thank you for looking into this. Let me know if you have a patch
> which you want me to test on a RTL8723BS adapter.

Could you test this instead?

https://p.sipsolutions.net/235c352b8ae5db88.txt

I don't have that much sympathy for a staging driver that's clearly
doing things differently than it was intended (the documentation states
that the function should be called only before wiphy_register(), not
during ndo_open). :-)

But OTOH, that fix to the driver is simple and looks correct to me since
it only ever has a static regdomain, and the notifier does the work of
applying it to the channels as well.

> One thing which I forgot to mention earlier, it is not just lockdep complaining
> this appears to be a real deadlock, the wifi no longer functions, where
> as it does function with the patch drops.

Right.

johannes