netdev - Re: [PATCH 2/2 net-next] net: mscc: ocelot: fix error code in mscc_ocelot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210125132306.czc7thwgd3o3lbnw@skbuf>
Date:   Mon, 25 Jan 2021 13:23:07 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 2/2 net-next] net: mscc: ocelot: fix error code in
 mscc_ocelot_probe()

On Mon, Jan 25, 2021 at 11:13:19AM +0300, Dan Carpenter wrote:
> Probe should return an error code if platform_get_irq_byname() fails
> but it returns success instead.
> 
> Fixes: 6c30384eb1de ("net: mscc: ocelot: register devlink ports")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>