netdev - RE: [PATCH iproute2-next RESEND] devlink: Extend man page for port function set command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR12MB4322F470143709A0294F1463DCBC9@BY5PR12MB4322.namprd12.prod.outlook.com>
Date:   Tue, 26 Jan 2021 13:23:35 +0000
From:   Parav Pandit <parav@...dia.com>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "stephen@...workplumber.org" <stephen@...workplumber.org>,
        "dsahern@...nel.org" <dsahern@...nel.org>
CC:     Jiri Pirko <jiri@...dia.com>
Subject: RE: [PATCH iproute2-next RESEND] devlink: Extend man page for port
 function set command

Hi Stephen,

> From: Parav Pandit <parav@...dia.com>
> Sent: Friday, January 22, 2021 10:32 AM
> 
> Extended devlink-port man page for synopsis, description and example for
> setting devlink port function attribute.
> 
> Signed-off-by: Parav Pandit <parav@...dia.com>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>

Can you please review this short update?

> ---
>  man/man8/devlink-port.8 | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/man/man8/devlink-port.8 b/man/man8/devlink-port.8 index
> 966faae6..7e2dc110 100644
> --- a/man/man8/devlink-port.8
> +++ b/man/man8/devlink-port.8
> @@ -46,6 +46,12 @@ devlink-port \- devlink port configuration  .ti -8  .B
> devlink port help
> 
> +.ti -8
> +.BR "devlink port function set "
> +.RI "[ "
> +.BR "hw_addr "
> +.RI "ADDR ]"
> +
>  .SH "DESCRIPTION"
>  .SS devlink port set - change devlink port attributes
> 
> @@ -99,6 +105,16 @@ If this argument is omitted all ports are listed.
>  Is an alias for
>  .BR devlink-health (8).
> 
> +.SS devlink port function set - Set the port function attribute.
> +
> +.PP
> +.B "DEV/PORT_INDEX"
> +- specifies the devlink port to operate on.
> +
> +.PP
> +.BI hw_addr " ADDR"
> +- hardware address of the function to set.
> +
>  .SH "EXAMPLES"
>  .PP
>  devlink port show
> @@ -135,6 +151,11 @@ devlink port health show pci/0000:01:00.0/1 reporter
> tx  .RS 4  Shows status and configuration of tx reporter registered on
> pci/0000:01:00.0/1 devlink port.
>  .RE
> +.PP
> +devlink port function set pci/0000:01:00.0/1 hw_addr 00:00:00:11:22:33
> +.RS 4 Configure hardware address of the PCI function represented by
> +devlink port.
> +.RE
> 
>  .SH SEE ALSO
>  .BR devlink (8),
> --
> 2.26.2