netdev - Re: pull-request: mac80211 2021-01-18.2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Jan 2021 13:59:03 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Johannes Berg <johannes@...solutions.net>,
        "Peer, Ilan" <ilan.peer@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "Coelho, Luciano" <luciano.coelho@...el.com>
Subject: Re: pull-request: mac80211 2021-01-18.2

Hi,

On 1/25/21 1:40 PM, Johannes Berg wrote:
> Hi,
> 
>>> I don't have that much sympathy for a staging driver that's clearly
>>> doing things differently than it was intended (the documentation states
>>> that the function should be called only before wiphy_register(), not
>>> during ndo_open). :-)
>>
>> I completely understand and I already was worried that this might be
>> a staging-driver issue, which is why I mentioned this was with a
>> staging driver in the more detailed bug-report email.
> 
> I guess I missed that, but no worries.
> 
>>> But OTOH, that fix to the driver is simple and looks correct to me since
>>> it only ever has a static regdomain, and the notifier does the work of
>>> applying it to the channels as well.
>>
>> So I've given your fix a quick try and it leads to a NULL pointer deref.
> 
> Ouch. Oh. I see, that driver is *really* stupid, trying to get to the
> wiphy from the adapter, but going through the wdev instead ... ouch.
> 
> Wow are these pointers a mess in that driver ... Something like this,
> perhaps?
> 
> https://p.sipsolutions.net/4400d9a3b7b800bb.txt

Yes this fixes things, thank you that saves me from having to debug
the NULL ptr deref.

Do you want to submit this to Greg, or shall I (I've already
added it to me local tree as a commit with you as the author) ?

If you want me to submit it upstream, may I have / add your S-o-b
for this ?

Regards,

Hans