netdev - Re: [PATCH net] iwlwifi: provide gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210126123207.5c79f4c0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 26 Jan 2021 12:32:07 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Ben Greear <greearb@...delatech.com>,
        Luca Coelho <luciano.coelho@...el.com>,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH net] iwlwifi: provide gso_type to GSO packets

On Mon, 25 Jan 2021 07:09:49 -0800 Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> net/core/tso.c got recent support for USO, and this broke iwlfifi
> because the driver implemented a limited form of GSO.
> 
> Providing ->gso_type allows for skb_is_gso_tcp() to provide
> a correct result.
> 
> Fixes: 3d5b459ba0e3 ("net: tso: add UDP segmentation support")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Ben Greear <greearb@...delatech.com>
> Bisected-by: Ben Greear <greearb@...delatech.com>
> Tested-by: Ben Greear <greearb@...delatech.com>
> Cc: Luca Coelho <luciano.coelho@...el.com>
> Cc: linux-wireless@...r.kernel.org
> Cc: Johannes Berg <johannes@...solutions.net>

Johannes, Eric tagged this for net, are you okay with me taking it?
No strong preference here.