netdev - Re: [PATCH net-next v2] net: qmi_wwan: Add pass through mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd8fd0162cd56d44a56fd389339ec3e6e4b65bd8.camel@redhat.com>
Date:   Mon, 25 Jan 2021 13:00:21 -0600
From:   Dan Williams <dcbw@...hat.com>
To:     Bjørn Mork <bjorn@...k.no>
Cc:     Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>,
        davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        stranche@...eaurora.org, aleksander@...ksander.es,
        dnlplm@...il.com, stephan@...hold.net, ejcaruso@...gle.com,
        andrewlassalle@...gle.com
Subject: Re: [PATCH net-next v2] net: qmi_wwan: Add pass through mode

On Mon, 2021-01-25 at 17:00 +0100, Bjørn Mork wrote:
> Dan Williams <dcbw@...hat.com> writes:
> > On Mon, 2021-01-25 at 00:33 -0700, Subash Abhinov Kasiviswanathan
> > wrote:
> > > Pass through mode is to allow packets in MAP format to be passed
> > > on to the stack. rmnet driver can be used to process and
> > > demultiplex
> > > these packets.
> > > 
> > > Pass through mode can be enabled when the device is in raw ip
> > > mode
> > > only.
> > > Conversely, raw ip mode cannot be disabled when pass through mode
> > > is
> > > enabled.
> > > 
> > > Userspace can use pass through mode in conjunction with rmnet
> > > driver
> > > through the following steps-
> > > 
> > > 1. Enable raw ip mode on qmi_wwan device
> > > 2. Enable pass through mode on qmi_wwan device
> > > 3. Create a rmnet device with qmi_wwan device as real device
> > > using
> > > netlink
> > 
> > This option is module-wide, right?
> > 
> > eg, if there are multiple qmi_wwan-driven devices on the system,
> > *all*
> > of them must use MAP + passthrough, or none of them can, right?
> 
> No, this is a per-netdev setting, just like the raw-ip flag.

Thanks for setting me straight. Glad to hear it.
Dan