netdev - RE: [PATCH V3 1/6] net: stmmac: remove redundant null check for ptp clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Jan 2021 01:49:04 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>
CC:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Jose Abreu <joabreu@...opsys.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Network Development <netdev@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>, Andrew Lunn <andrew@...n.ch>
Subject: RE: [PATCH V3 1/6] net: stmmac: remove redundant null check for ptp
 clock


> -----Original Message-----
> From: Florian Fainelli <f.fainelli@...il.com>
> Sent: 2021年1月27日 9:33
> To: Joakim Zhang <qiangqing.zhang@....com>; Willem de Bruijn
> <willemdebruijn.kernel@...il.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>; Alexandre Torgue
> <alexandre.torgue@...com>; Jose Abreu <joabreu@...opsys.com>; David
> Miller <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; Network
> Development <netdev@...r.kernel.org>; dl-linux-imx <linux-imx@....com>;
> Andrew Lunn <andrew@...n.ch>
> Subject: Re: [PATCH V3 1/6] net: stmmac: remove redundant null check for ptp
> clock
> 
> 
> 
> On 1/26/2021 5:30 PM, Joakim Zhang wrote:
> >
> >> -----Original Message-----
> >> From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> >> Sent: 2021年1月27日 6:46
> >> To: Joakim Zhang <qiangqing.zhang@....com>
> >> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>; Alexandre Torgue
> >> <alexandre.torgue@...com>; Jose Abreu <joabreu@...opsys.com>; David
> >> Miller <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>;
> >> Network Development <netdev@...r.kernel.org>; dl-linux-imx
> >> <linux-imx@....com>; Andrew Lunn <andrew@...n.ch>; Florian Fainelli
> >> <f.fainelli@...il.com>
> >> Subject: Re: [PATCH V3 1/6] net: stmmac: remove redundant null check
> >> for ptp clock
> >>
> >> On Tue, Jan 26, 2021 at 7:05 AM Joakim Zhang
> >> <qiangqing.zhang@....com>
> >> wrote:
> >>>
> >>> Remove redundant null check for ptp clock.
> >>>
> >>> Fixes: 1c35cc9cf6a0 ("net: stmmac: remove redundant null check
> >>> before
> >>> clk_disable_unprepare()")
> >>
> >> This does not look like a fix to that patch, but another instance of a cleanup.
> >>
> >> The patchset also does not explicitly target net (for fixes) or
> >> net-next (for new improvements). I suppose this patch targets net-next.
> >
> > I forgot to explicitly target as net when format the patch set again. This could
> be a fix even original patch(1c35cc9cf6a0) doesn't break anything, but it didn't
> do all the work as commit message commit.
> > This patch targets net or net-next, this matter doesn't seem to be that
> important. If it is necessary, I can repost it next time as a separate patch for
> net-next. Thanks.
> 
> Your patch series is titled "ethernet: fixes for stmmac driver" so we sort of
> expect to find only bug fixes in there.
> 
> Given this patch has no dependency and does not create one on the others, you
> should post that as a separate patch targeting the 'net-next' tree.

Ok, I will remove this patch from patch set next version. Thanks.

Best Regards,
Joakim Zhang
> --
> Florian