netdev - Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210127142220.43aecad8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 27 Jan 2021 14:22:20 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     Chris Mi <cmi@...dia.com>, netdev@...r.kernel.org, jiri@...dia.com
Subject: Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC
 driver dependency

On Tue, 26 Jan 2021 20:50:28 -0800 Saeed Mahameed wrote:
> On Tue, 2021-01-26 at 18:49 -0800, Jakub Kicinski wrote:
> > On Tue, 26 Jan 2021 22:59:29 +0800 Chris Mi wrote:  
> > > In order to send sampled packets to userspace, NIC driver calls
> > > psample api directly. But it creates a hard dependency on module
> > > psample. Introduce psample_ops to remove the hard dependency.
> > > It is initialized when psample module is loaded and set to NULL
> > > when the module is unloaded.
> > > 
> > > Signed-off-by: Chris Mi <cmi@...dia.com>
> > > Reviewed-by: Jiri Pirko <jiri@...dia.com>  
> > 
> > This adds a bunch of sparse warnings.
> > 
> > MelVidia has some patch checking infra, right? Any reason this was
> > not
> > run through it?  
> 
> we do but we don't test warnings on non mlnx files, as we rely on the
> fact that our mlnx files are clean, We simply don't check for
> "added/diff" warnings, we check that mlnx files are kept clean, easier
> :) ..
> 
> Anyway I am working internally to clone/copy nipa into our CI.. hope it
> will work smoothly .. 

Exciting! :)