netdev - Re: [Intel-wired-lan] [PATCH net-next] ice: remove redundant null check on pf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f8a08a517fbe6977c1777c77067d800d0bbbc9ad.camel@intel.com>
Date:   Wed, 27 Jan 2021 23:37:21 +0000
From:   "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
To:     "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "wangyunjian@...wei.com" <wangyunjian@...wei.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "jerry.lilijun@...wei.com" <jerry.lilijun@...wei.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "xudingke@...wei.com" <xudingke@...wei.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next] ice: remove redundant null
 check on pf

On Wed, 2021-01-27 at 19:50 +0800, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@...wei.com>
> 
> Before calling ice_set_dflt_mib(), the 'pf' has been dereferenced.
> So the additional check is unnecessary, just remove it.
> 
> Addresses-Coverity: ("Dereference before null check")
> Fixes: 7d9c9b791f9e ("ice: Implement LFC workaround")
> Signed-off-by: Yunjian Wang <wangyunjian@...wei.com>
> ---

Thanks for the patch Yunjian. However, we do have a patch coming[1]
that fixes this issue.

Thanks,
Tony

[1] https://patchwork.ozlabs.org/project/intel-wired-
lan/patch/20201012225326.15722-1-anthony.l.nguyen@...el.com/