netdev - Re: [PATCH net-next 06/10] net: Pass 'net' struct as first argument to fib6_info_hw_flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a079f7db-a811-de7f-077f-c1d3057735de@gmail.com>
Date:   Tue, 26 Jan 2021 22:08:40 -0700
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, amcohen@...dia.com,
        roopa@...dia.com, sharpd@...dia.com, bpoirier@...dia.com,
        mlxsw@...dia.com, Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next 06/10] net: Pass 'net' struct as first argument
 to fib6_info_hw_flags_set()

On 1/26/21 6:23 AM, Ido Schimmel wrote:
> From: Amit Cohen <amcohen@...dia.com>
> 
> The next patch will emit notification when hardware flags are changed,
> in case that fib_notify_on_flag_change sysctl is set to 1.
> 
> To know sysctl values, net struct is needed.
> This change is consistent with the IPv4 version, which gets 'net' struct
> as its first argument.
> 
> Currently, the only callers of this function are mlxsw and netdevsim.
> Patch the callers to pass net.
> 
> Signed-off-by: Amit Cohen <amcohen@...dia.com>
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  .../net/ethernet/mellanox/mlxsw/spectrum_router.c  |  7 ++++---
>  drivers/net/netdevsim/fib.c                        | 14 ++++++++------
>  include/net/ip6_fib.h                              |  5 +++--
>  3 files changed, 15 insertions(+), 11 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>