netdev - Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0837f7ce-cdb9-fe3e-ac10-acfc3e35ee30@nvidia.com>
Date:   Wed, 27 Jan 2021 11:42:13 +0800
From:   Chris Mi <cmi@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, <jiri@...dia.com>, <saeedm@...dia.com>
Subject: Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC
 driver dependency

Hi Jakub,

On 1/27/2021 10:49 AM, Jakub Kicinski wrote:
> On Tue, 26 Jan 2021 22:59:29 +0800 Chris Mi wrote:
>> In order to send sampled packets to userspace, NIC driver calls
>> psample api directly. But it creates a hard dependency on module
>> psample. Introduce psample_ops to remove the hard dependency.
>> It is initialized when psample module is loaded and set to NULL
>> when the module is unloaded.
>>
>> Signed-off-by: Chris Mi <cmi@...dia.com>
>> Reviewed-by: Jiri Pirko <jiri@...dia.com>
> This adds a bunch of sparse warnings.
>
> MelVidia has some patch checking infra, right? Any reason this was not
> run through it?
Could you please tell me what's sparse warnings you hit?
Just now I ran ./scripts/checkpatch.pl again without "--ignore 
FILE_PATH_CHANGES",
I got the following warning:

WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does 
MAINTAINERS need updating?
#128:
new file mode 100644

I'll change it. But I'm not sure if this is the only thing I need to change.
So could you please elaborate? I'll pay attention to it in the future.

Thanks,
Chris