netdev - Re: [PATCH net] iwlwifi: provide gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3aedacff5e5c37a735a2a6da2a8042efcd530eb2.camel@intel.com>
Date:   Wed, 27 Jan 2021 06:02:12 +0000
From:   "Coelho, Luciano" <luciano.coelho@...el.com>
To:     "johannes@...solutions.net" <johannes@...solutions.net>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "greearb@...delatech.com" <greearb@...delatech.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "eric.dumazet@...il.com" <eric.dumazet@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] iwlwifi: provide gso_type to GSO packets

On Tue, 2021-01-26 at 21:55 +0100, Johannes Berg wrote:
> On Tue, 2021-01-26 at 12:32 -0800, Jakub Kicinski wrote:
> > On Mon, 25 Jan 2021 07:09:49 -0800 Eric Dumazet wrote:
> > > From: Eric Dumazet <edumazet@...gle.com>
> > > 
> > > net/core/tso.c got recent support for USO, and this broke iwlfifi
> > > because the driver implemented a limited form of GSO.
> > > 
> > > Providing ->gso_type allows for skb_is_gso_tcp() to provide
> > > a correct result.
> > > 
> > > Fixes: 3d5b459ba0e3 ("net: tso: add UDP segmentation support")
> > > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > > Reported-by: Ben Greear <greearb@...delatech.com>
> > > Bisected-by: Ben Greear <greearb@...delatech.com>
> > > Tested-by: Ben Greear <greearb@...delatech.com>
> > > Cc: Luca Coelho <luciano.coelho@...el.com>
> > > Cc: linux-wireless@...r.kernel.org
> > > Cc: Johannes Berg <johannes@...solutions.net>
> > 
> > Johannes, Eric tagged this for net, are you okay with me taking it?
> > No strong preference here.
> 
> I guess that really would normally go through Luca's and Kalle's trees,
> but yes, please just take it, it's been long and it won't conflict with
> anything.

Yes, that's fine by me too.  Just take it via net and we'll get it into
our trees eventually.

--
Cheers,
Luca.