netdev - Re: [PATCH 00/12] Rid W=1 warnings from Thunderbolt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210128110904.GR2542@lahna.fi.intel.com>
Date:   Thu, 28 Jan 2021 13:09:04 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Andreas Noever <andreas.noever@...il.com>, bpf@...r.kernel.org,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        linux-usb@...r.kernel.org, Michael Jamet <michael.jamet@...el.com>,
        netdev@...r.kernel.org, Yehezkel Bernat <YehezkelShB@...il.com>
Subject: Re: [PATCH 00/12] Rid W=1 warnings from Thunderbolt

Hi Lee,

On Wed, Jan 27, 2021 at 11:25:42AM +0000, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
> 
> Only 1 small set required for Thunderbolt.  Pretty good!
> 
> Lee Jones (12):
>   thunderbolt: dma_port: Remove unused variable 'ret'
>   thunderbolt: cap: Fix kernel-doc formatting issue
>   thunderbolt: ctl: Demote non-conformant kernel-doc headers
>   thunderbolt: eeprom: Demote non-conformant kernel-doc headers to
>     standard comment blocks
>   thunderbolt: pa: Demote non-conformant kernel-doc headers
>   thunderbolt: xdomain: Fix 'tb_unregister_service_driver()'s 'drv'
>     param
>   thunderbolt: nhi: Demote some non-conformant kernel-doc headers
>   thunderbolt: tb: Kernel-doc function headers should document their
>     parameters
>   thunderbolt: swit: Demote a bunch of non-conformant kernel-doc headers
>   thunderbolt: icm: Fix a couple of formatting issues
>   thunderbolt: tunnel: Fix misspelling of 'receive_path'
>   thunderbolt: swit: Fix function name in the header

I applied all of the changes that touch static functions. For non-static
functions I will send a patch set shortly that adds the missing bits for
the kernel-doc descriptions. I also fixed $subject lines of few patches
("switch:" instead of "swit:").

Please check that I got everything correct in

  git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git next

Thanks!