netdev - Re: [PATCH net-next 2/4] net: dsa: automatically bring user ports down when master goes down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YBIKuNW2H2ygODxP@lunn.ch>
Date:   Thu, 28 Jan 2021 01:52:08 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH net-next 2/4] net: dsa: automatically bring user ports
 down when master goes down

On Thu, Jan 28, 2021 at 02:50:14AM +0200, Vladimir Oltean wrote:
> On Thu, Jan 28, 2021 at 01:46:30AM +0100, Andrew Lunn wrote:
> > > +	case NETDEV_GOING_DOWN: {
> > > +		struct dsa_port *dp, *cpu_dp;
> > > +		struct dsa_switch_tree *dst;
> > > +		int err = 0;
> > > +
> > > +		if (!netdev_uses_dsa(dev))
> > > +			return NOTIFY_DONE;
> > > +
> > > +		cpu_dp = dev->dsa_ptr;
> > > +		dst = cpu_dp->ds->dst;
> > > +
> > > +		list_for_each_entry(dp, &dst->ports, list) {
> > > +			if (!dsa_is_user_port(dp->ds, dp->index)) {
> >
> > !dsa_is_user_port() ??
> >
> > That ! seems odd.
> 
> Oops, that's something that I refactored at the last minute after I
> prototyped the idea from:
> 			if (!dsa_is_user_port(dp->ds, dp->index))
> 				continue;
> because it looked uglier that way.

I was guessing it would be something like that. With that fixed:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew