netdev - Re: [PATCH net-next] net: dsa: hellcreek: Add missing TAPRIO dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2xpYcnzJiyWUBic34M1G_R3c_VOqjNkh0F5x9DNkhQ2g@mail.gmail.com>
Date:   Thu, 28 Jan 2021 18:02:33 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Kurt Kanzenbach <kurt@...utronix.de>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Networking <netdev@...r.kernel.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH net-next] net: dsa: hellcreek: Add missing TAPRIO dependency

On Thu, Jan 28, 2021 at 5:37 PM Vladimir Oltean <olteanv@...il.com> wrote:
>
> On Thu, Jan 28, 2021 at 05:33:38PM +0100, Kurt Kanzenbach wrote:
> > Add missing dependency to TAPRIO to avoid build failures such as:
> >
> > |ERROR: modpost: "taprio_offload_get" [drivers/net/dsa/hirschmann/hellcreek_sw.ko] undefined!
> > |ERROR: modpost: "taprio_offload_free" [drivers/net/dsa/hirschmann/hellcreek_sw.ko] undefined!
> >
> > Fixes: 24dfc6eb39b2 ("net: dsa: hellcreek: Add TAPRIO offloading support")
> > Reported-by: Randy Dunlap <rdunlap@...radead.org>
> > Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>

Acked-by: Arnd Bergmann <arnd@...db.de>

> Note that for sja1105, Arnd solved it this way. I am still not sure why.
>
> commit 5d294fc483405de9c0913ab744a31e6fa7cb0f40
> Author: Arnd Bergmann <arnd@...db.de>
> Date:   Fri Oct 25 09:26:35 2019 +0200
>
>     net: dsa: sja1105: improve NET_DSA_SJA1105_TAS dependency
>
>     An earlier bugfix introduced a dependency on CONFIG_NET_SCH_TAPRIO,
>     but this missed the case of NET_SCH_TAPRIO=m and NET_DSA_SJA1105=y,
>     which still causes a link error:
>

As I described in this commit, the problem here was that NET_DSA_SJA1105_TAS
is a 'bool' symbol with a dependency on a 'tristate', so you have to prevent
the option from getting enabled when it's part of a driver that gets built into
the kernel but the dependnecy is in a loadable module.

NET_DSA_HIRSCHMANN_HELLCREEK on the other hand is a 'tristate'
symbol itself, so the dependency takes care of it: you cannot set it to =y
when its dependency is =m.

         Arnd