netdev - Re: [net] udp: exclude UDP_ENCAP_RXRPC packets from early demux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1ae64181-bd97-4975-c534-c19e62e04324@novek.ru>
Date:   Fri, 29 Jan 2021 17:25:04 +0000
From:   Vadim Fedorenko <vfedorenko@...ek.ru>
To:     Jakub Kicinski <kuba@...nel.org>, David Ahern <dsahern@...nel.org>,
        David Howells <dhowells@...hat.com>
Cc:     linux-afs@...ts.infradead.org, netdev@...r.kernel.org
Subject: Re: [net] udp: exclude UDP_ENCAP_RXRPC packets from early demux

On 29.01.2021 14:25, Vadim Fedorenko wrote:
> While adding the early demux for udp sockets rxrpc were not
> changed to deal with sk_rx_dst cache. That leads to leaking early
> demux cache dst reference. But adding dst_release to destructor of
> rxrpc doesn't help in situation of destroying namespace. This is
> because rxrpc does not register any netdevices per namespace.
> Assigned sk->sk_rx_dst holds the reference to netdevice preventing
> successful freeing of netdevices in namespace and moving forward to
> subsystem freeing. This is dead lock situation.
> 
> Removing rxrpc sockets from early demux util the solution in rxrpc
> subsystem is made.

Skip this please, as David Howells sent corrections to rxrpc