netdev - Re: [PATCH net-next V1] net: adjust net_device layout for cacheline usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28a12f2b-3c46-c428-ddc2-de702ef33d3f@gmail.com>
Date:   Fri, 29 Jan 2021 20:47:41 +0100
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>, bpf@...r.kernel.org,
        Eric Dumazet <eric.dumazet@...il.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>
Subject: Re: [PATCH net-next V1] net: adjust net_device layout for cacheline
 usage



On 1/29/21 8:35 PM, Jakub Kicinski wrote:

> kdoc didn't complain, and as you say it's already a mess, plus it's
> two screen-fulls of scrolling away... 
> 
> I think converting to inline kdoc of members would be an improvement,
> if you want to sign up for that? Otherwise -EDIDNTCARE on my side :)
> 

What about removing this kdoc ?

kdoc for a huge structure is mostly useless...