[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c3eab4cb5c401a0273bf3b391d1b72dd46ee9921.camel@kernel.org>
Date: Fri, 29 Jan 2021 12:44:59 -0800
From: Saeed Mahameed <saeed@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>, Chris Mi <cmi@...dia.com>
Cc: Cong Wang <xiyou.wangcong@...il.com>,
Linux Kernel Network Developers <netdev@...r.kernel.org>,
jiri@...dia.com, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC
driver dependency
On Fri, 2021-01-29 at 12:30 -0800, Jakub Kicinski wrote:
> On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote:
> > Instead of discussing it several days, maybe it's better to review
> > current patch, so that we can move forward :)
>
> It took you 4 revisions to post a patch which builds cleanly and now
> you want to hasten the review? My favorite kind of submission.
>
> The mlxsw core + spectrum drivers are 65 times the size of psample
> on my system. Why is the dependency a problem?
>
> What's going to make sure the module gets loaded when it's needed?
The issue is with distros who ship modules independently.. having a
hard dependency will make it impossible for basic mlx5_core.ko users to
load the driver when psample is not installed/loaded.
I prefer to have 0 dependency on external modules in a HW driver.
Thanks,
Saeed.
Powered by blists - more mailing lists