netdev - Re: [PATCH net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2021-01-28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-JSdgTnXwVukkvHYNspWzJf0zrx2Qqfv3XHcbkvQ+Hs_g@mail.gmail.com>
Date:   Fri, 29 Jan 2021 16:37:14 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Network Development <netdev@...r.kernel.org>,
        sassmann@...hat.com
Subject: Re: [PATCH net-next 00/15][pull request] 100GbE Intel Wired LAN
 Driver Updates 2021-01-28

On Thu, Jan 28, 2021 at 7:44 PM Tony Nguyen <anthony.l.nguyen@...el.com> wrote:
>
> This series contains updates to ice driver only.
>
> Jake adds devlink reporting of security revision fields associated with
> 'fw.undi' and 'fw.mgmt'. Also implements support for displaying and
> updating the minimum security revision fields for the device as
> driver-specific devlink parameters. And adds reporting of timeout length
> during devlink flash.
>
> He also implements support to report devlink info regarding the version of
> firmware that is stored (downloaded) to the device, but is not yet active.
> This includes the UNDI Option ROM, the Netlist module, and the
> fw.bundle_id.
>
> Changes include:
>    Refactoring version reporting to allow for a context structure.
>
>    ice_read_flash_module is further abstracted to think in terms of
>    "active" and "inactive" banks, rather than focusing on "read from
>    the 1st or 2nd bank". Further, the function is extended to allow
>    reading arbitrary sizes beyond just one word at a time.
>
>    Extend the version function to allow requesting the flash bank to read
>    from (active or inactive).
>
> Gustavo A. R. Silva replaces a one-element array to flexible-array
> member.
>
> Bruce utilizes flex_array_size() helper and removes dead code on a check
> for a condition that can't occur.
>
> The following are changes since commit 32e31b78272ba0905c751a0f6ff6ab4c275a780e:
>   Merge branch 'net-sfp-add-support-for-gpon-rtl8672-rtl9601c-and-ubiquiti-u-fiber'
> and are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 100GbE
>
> Bruce Allan (2):
>   ice: use flex_array_size where possible
>   ice: remove dead code
>
> Gustavo A. R. Silva (1):
>   ice: Replace one-element array with flexible-array member
>
> Jacob Keller (12):
>   ice: create flash_info structure and separate NVM version
>   ice: cache NVM module bank information
>   ice: read security revision to ice_nvm_info and ice_orom_info
>   ice: add devlink parameters to read and write minimum security
>     revision
>   ice: report timeout length for erasing during devlink flash
>   ice: introduce context struct for info report
>   ice: refactor interface for ice_read_flash_module
>   ice: allow reading inactive flash security revision
>   ice: allow reading arbitrary size data with read_flash_module
>   ice: display some stored NVM versions via devlink info
>   ice: display stored netlist versions via devlink info
>   ice: display stored UNDI firmware version via devlink info
>
>  Documentation/networking/devlink/ice.rst      |  43 +
>  drivers/net/ethernet/intel/ice/ice.h          |   2 +-
>  .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  40 +-
>  drivers/net/ethernet/intel/ice/ice_common.c   |   2 +-
>  drivers/net/ethernet/intel/ice/ice_devlink.c  | 496 +++++++++-
>  drivers/net/ethernet/intel/ice/ice_devlink.h  |   2 +
>  drivers/net/ethernet/intel/ice/ice_ethtool.c  |   8 +-
>  .../net/ethernet/intel/ice/ice_flex_pipe.c    |   2 +-
>  .../net/ethernet/intel/ice/ice_fw_update.c    |  10 +-
>  drivers/net/ethernet/intel/ice/ice_main.c     |  19 +-
>  drivers/net/ethernet/intel/ice/ice_nvm.c      | 876 +++++++++++++++---
>  drivers/net/ethernet/intel/ice/ice_nvm.h      |  18 +
>  drivers/net/ethernet/intel/ice/ice_status.h   |   1 +
>  drivers/net/ethernet/intel/ice/ice_type.h     | 141 ++-
>  14 files changed, 1427 insertions(+), 233 deletions(-)

For netdrv

Acked-by: Willem de Bruijn <willemb@...gle.com>

Very clear code and documentation, thanks!