netdev - Re: [net v3] net: ip_tunnel: fix mtu calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20210129140505.37a95f4a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 29 Jan 2021 14:05:05 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Vadim Fedorenko <vfedorenko@...ek.ru>
Cc:     "Willem de Bruijn <willemdebruijn.kernel@...il.com>--to=Slava Bacherikov" 
        <mail@...va.cc>, Network Development <netdev@...r.kernel.org>
Subject: Re: [net v3] net: ip_tunnel: fix mtu calculation

On Fri, 29 Jan 2021 10:29:29 -0500 Willem de Bruijn wrote:
> On Fri, Jan 29, 2021 at 9:45 AM Vadim Fedorenko <vfedorenko@...ek.ru> wrote:
> >
> > dev->hard_header_len for tunnel interface is set only when header_ops
> > are set too and already contains full overhead of any tunnel encapsulation.
> > That's why there is not need to use this overhead twice in mtu calc.
> >
> > Fixes: fdafed459998 ("ip_gre: set dev->hard_header_len and dev->needed_headroom properly")
> > Reported-by: Slava Bacherikov <mail@...va.cc>
> > Signed-off-by: Vadim Fedorenko <vfedorenko@...ek.ru>  
> 
> Acked-by: Willem de Bruijn <willemb@...gle.com>

Thanks!

I think vger ate this one, Vadim, could you repost?