netdev - Re: [PATCH net] net: sched: replaced invalid qdisc tree flush helper in qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXm6FpaS2YiFE3br6Ktx0fR2xqxyAuJC_LzBcYYiwa9+w@mail.gmail.com>
Date:   Fri, 29 Jan 2021 15:22:50 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Alexander Ovechkin <ovov@...dex-team.ru>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>, zeil@...dex-team.ru,
        dmtrmonakhov@...dex-team.ru
Subject: Re: [PATCH net] net: sched: replaced invalid qdisc tree flush helper
 in qdisc_replace

On Fri, Jan 29, 2021 at 4:02 AM Alexander Ovechkin <ovov@...dex-team.ru> wrote:
>
> Commit e5f0e8f8e456 ("net: sched: introduce and use qdisc tree flush/purge helpers")
> introduced qdisc tree flush/purge helpers, but erroneously used flush helper
> instead of purge helper in qdisc_replace function.
> This issue was found in our CI, that tests various qdisc setups by configuring
> qdisc and sending data through it. Call of invalid helper sporadically leads
> to corruption of vt_tree/cf_tree of hfsc_class that causes kernel oops:
...
> Fixes: e5f0e8f8e456 ("net: sched: introduce and use qdisc tree flush/purge helpers")
> Signed-off-by: Alexander Ovechkin <ovov@...dex-team.ru>

Looks reasonable to me:

Acked-by: Cong Wang <xiyou.wangcong@...il.com>

Thanks.