netdev - Re: [PATCH net-next 05/12] nexthop: Use enum to encode notification type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <005e0faf-7021-7ec7-e6b3-33892db120c3@gmail.com>
Date:   Thu, 28 Jan 2021 20:12:37 -0700
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <petrm@...dia.com>, netdev@...r.kernel.org
Cc:     David Ahern <dsahern@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next 05/12] nexthop: Use enum to encode notification
 type

On 1/28/21 5:49 AM, Petr Machata wrote:
> From: Ido Schimmel <idosch@...dia.com>
> 
> Currently there are only two types of in-kernel nexthop notification.
> The two are distinguished by the 'is_grp' boolean field in 'struct
> nh_notifier_info'.
> 
> As more notification types are introduced for more next-hop group types, a
> boolean is not an easily extensible interface. Instead, convert it to an
> enum.
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> Reviewed-by: Petr Machata <petrm@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>
> ---
>  .../ethernet/mellanox/mlxsw/spectrum_router.c | 54 ++++++++++++++-----
>  drivers/net/netdevsim/fib.c                   | 23 ++++----
>  include/net/nexthop.h                         |  7 ++-
>  net/ipv4/nexthop.c                            | 14 ++---
>  4 files changed, 69 insertions(+), 29 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>