netdev - Re: [PATCH net-next 09/12] nexthop: Strongly-type context of rtm_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fda6a9ba-48c1-c4f1-b1f9-05346e7f96c3@gmail.com>
Date:   Thu, 28 Jan 2021 20:18:34 -0700
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <petrm@...dia.com>, netdev@...r.kernel.org
Cc:     David Ahern <dsahern@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next 09/12] nexthop: Strongly-type context of
 rtm_dump_nexthop()

On 1/28/21 5:49 AM, Petr Machata wrote:
> The dump operations need to keep state from one invocation to another. A
> scratch area is dedicated for this purpose in the passed-in argument, cb,
> namely via two aliased arrays, struct netlink_callback.args and .ctx.
> 
> Dumping of buckets will end up having to iterate over next hops as well,
> and it would be nice to be able to reuse the iteration logic with the NH
> dumper. The fact that the logic currently relies on fixed index to the
> .args array, and the indices would have to be coordinated between the two
> dumpers, makes this somewhat awkward.
> 
> To make the access patters clearer, introduce a helper struct with a NH
> index, and instead of using the .args array directly, use it through this
> structure.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> ---
>  net/ipv4/nexthop.c | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>