netdev - Re: [PATCH net-next 12/12] nexthop: Extract a helper for validation of get/del RTNL requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49569963-f202-373d-7624-9bc94612fbd2@gmail.com>
Date:   Thu, 28 Jan 2021 20:21:56 -0700
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <petrm@...dia.com>, netdev@...r.kernel.org
Cc:     David Ahern <dsahern@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next 12/12] nexthop: Extract a helper for validation
 of get/del RTNL requests

On 1/28/21 5:49 AM, Petr Machata wrote:
> Validation of messages for get / del of a next hop is the same as will be
> validation of messages for get of a resilient next hop group bucket. The
> difference is that policy for resilient next hop group buckets is a
> superset of that used for next-hop get.
> 
> It is therefore possible to reuse the code that validates the nhmsg fields,
> extracts the next-hop ID, and validates that. To that end, extract from
> nh_valid_get_del_req() a helper __nh_valid_get_del_req() that does just
> that.
> 
> Make the nlh argument const so that the function can be called from the
> dump context, which only has a const nlh. Propagate the constness to
> nh_valid_get_del_req().
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> ---
>  net/ipv4/nexthop.c | 43 +++++++++++++++++++++++++------------------
>  1 file changed, 25 insertions(+), 18 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>