netdev - Re: Patch for stable: iwlwifi: provide gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210129193030.46ef3b17@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 29 Jan 2021 19:30:30 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Robert Hancock <hancockrwd@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: Patch for stable: iwlwifi: provide gso_type to GSO packets

On Fri, 29 Jan 2021 20:41:11 -0600 Robert Hancock wrote:
> Figured I would poke someone to add this patch to the stable queue - I
> don't see it in
> https://patchwork.kernel.org/bundle/netdev/stable/?state=* right now.
> This patch is reported to fix a severe upload speed regression in many
> Intel wireless adapters existing since kernel 5.9, as described in
> https://bugzilla.kernel.org/show_bug.cgi?id=209913

We're actually experimenting with letting Greg take networking patches
into stable like he does for every other tree. If the patch doesn't
appear in the next stable release please poke stable@ directly.

> commit 81a86e1bd8e7060ebba1718b284d54f1238e9bf9
> Author: Eric Dumazet <edumazet@...gle.com>
> Date:   Mon Jan 25 07:09:49 2021 -0800
> 
>     iwlwifi: provide gso_type to GSO packets
> 
>     net/core/tso.c got recent support for USO, and this broke iwlfifi
>     because the driver implemented a limited form of GSO.
> 
>     Providing ->gso_type allows for skb_is_gso_tcp() to provide
>     a correct result.
> 
>     Fixes: 3d5b459ba0e3 ("net: tso: add UDP segmentation support")
>     Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>     Reported-by: Ben Greear <greearb@...delatech.com>
>     Tested-by: Ben Greear <greearb@...delatech.com>
>     Cc: Luca Coelho <luciano.coelho@...el.com>
>     Cc: Johannes Berg <johannes@...solutions.net>
>     Link: https://bugzilla.kernel.org/show_bug.cgi?id=209913
>     Link: https://lore.kernel.org/r/20210125150949.619309-1-eric.dumazet@gmail.com
>     Signed-off-by: Jakub Kicinski <kuba@...nel.org>