netdev - Re: [Internal review][PATCH stable v5.4 1/2] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YBVIMvTN8ZFC+54U@kroah.com>
Date:   Sat, 30 Jan 2021 12:51:14 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Aviraj Cj (acj)" <acj@...co.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuznet@....inr.ac.ru" <kuznet@....inr.ac.ru>,
        "yoshfuji@...ux-ipv6.org" <yoshfuji@...ux-ipv6.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "xe-linux-external(mailer list)" <xe-linux-external@...co.com>,
        Hangbin Liu <liuhangbin@...il.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [Internal review][PATCH stable v5.4 1/2] ICMPv6: Add ICMPv6
 Parameter Problem, code 3 definition

On Sat, Jan 30, 2021 at 11:31:11AM +0000, Aviraj Cj (acj) wrote:
> 
> 
> On 30/01/21, 2:06 PM, "Greg KH" <gregkh@...uxfoundation.org> wrote:
> 
> On Sat, Jan 30, 2021 at 12:57:40AM +0530, Aviraj CJ wrote:
> > From: Hangbin Liu <liuhangbin@...il.com>
> > 
> > commit b59e286be280fa3c2e94a0716ddcee6ba02bc8ba upstream.
> > 
> > Based on RFC7112, Section 6:
> > 
> >    IANA has added the following "Type 4 - Parameter Problem" message to
> >    the "Internet Control Message Protocol version 6 (ICMPv6) Parameters"
> >    registry:
> > 
> >       CODE     NAME/DESCRIPTION
> >        3       IPv6 First Fragment has incomplete IPv6 Header Chain
> > 
> > Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > Signed-off-by: Aviraj CJ <acj@...co.com>
> > ---
> >  include/uapi/linux/icmpv6.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/uapi/linux/icmpv6.h b/include/uapi/linux/icmpv6.h
> > index 2622b5a3e616..9a31ea2ad1cf 100644
> > --- a/include/uapi/linux/icmpv6.h
> > +++ b/include/uapi/linux/icmpv6.h
> > @@ -137,6 +137,7 @@ struct icmp6hdr {
> >  #define ICMPV6_HDR_FIELD		0
> >  #define ICMPV6_UNK_NEXTHDR		1
> >  #define ICMPV6_UNK_OPTION		2
> > +#define ICMPV6_HDR_INCOMP		3
> >  
> >  /*
> >   *	constants for (set|get)sockopt
> > -- 
> > 2.26.2.Cisco
> > 
> 
> What do you mean by "internal review" and what am I supposed to do with
> this patch?  Same for the 2/2 patch in this series...
> <ACJ> Sorry " internal review" added by mistake, this is the correct patch for v5.4 branch, pls let me if u want me to send it by correcting...

Please fix and resend.

thanks,

greg k-h