netdev - RE: [EXT] Re: Phylink flow control support on ports with MLO_AN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO6PR18MB3873D6F519D1B4112AA77671B0B79@CO6PR18MB3873.namprd18.prod.outlook.com>
Date:   Sun, 31 Jan 2021 10:51:46 +0000
From:   Stefan Chulski <stefanc@...vell.com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
CC:     "andrew@...n.ch" <andrew@...n.ch>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Marcin Wojtas (mw@...ihalf.com)" <mw@...ihalf.com>,
        Nadav Haklai <nadavh@...vell.com>,
        "Yan Markman" <ymarkman@...vell.com>
Subject: RE: [EXT] Re: Phylink flow control support on ports with
  MLO_AN_FIXED auto negotiation


> > Hi,
> >
> > Armada has options for 1G/10G ports without PHY's(for example
> community board Macchiato single shot).
> > This port doesn't have PHY's and cannot negotiate Flow Control support,
> but we can for example connect two ports without PHY's and manually(by
> ethtool) configure FC.
> 
> On the Macchiatobin single shot, you use the existing SFP support rather
> than forcing them to fixed link.
> 
> > Current phylink return error if I do this on ports with
> MLO_AN_FIXED(callback phylink_ethtool_set_pauseparam):
> > if (pl->cur_link_an_mode == MLO_AN_FIXED)
> >                 return -EOPNOTSUPP;
> >
> > How can we enable FC configurations for these ports? Do you have any
> suggestions or should I post my proposal as an RFC patch?
> 
> If you really must use fixed-link, you specify the pause modes via firmware,
> just as you specify the speed and duplex - you specify the link partner's flow
> control abilities.

In this case we cannot change this by ethtool during runtime?

Regards,
Stefan.