netdev - Re: [PATCH net-next 3/3] net: mhi: Add mbim proto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bd01c51c592aa24c2dabc8e3afcbdbe9aa23bdc.camel@redhat.com>
Date:   Mon, 01 Feb 2021 12:17:17 -0600
From:   Dan Williams <dcbw@...hat.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Loic Poulain <loic.poulain@...aro.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, carl.yin@...ctel.com,
        Bjørn Mork <bjorn@...k.no>
Subject: Re: [PATCH net-next 3/3] net: mhi: Add mbim proto

On Fri, 2021-01-29 at 18:21 -0800, Jakub Kicinski wrote:
> On Wed, 27 Jan 2021 18:01:17 +0100 Loic Poulain wrote:
> > MBIM has initially been specified by USB-IF for transporting data
> > (IP)
> > between a modem and a host over USB. However some modern modems
> > also
> > support MBIM over PCIe (via MHI). In the same way as QMAP(rmnet),
> > it
> > allows to aggregate IP packets and to perform context multiplexing.
> > 
> > This change adds minimal MBIM support to MHI, allowing to support
> > MBIM
> > only modems. MBIM being based on USB NCM, it reuses some helpers
> > from
> > the USB stack, but the cdc-mbim driver is too USB coupled to be
> > reused.
> > 
> > At some point it would be interesting to move on a factorized
> > solution,
> > having a generic MBIM network lib or dedicated MBIM netlink virtual
> > interface support.

What would a kernel-side MBIM netlink interface do?  Just data-plane
stuff (like channel setup to create new netdevs), or are you thinking
about control-plane stuff like APN definition, radio scans, etc?

Dan

> > This code has been highly inspired from the mhi_mbim downstream
> > driver
> > (Carl Yin <carl.yin@...ctel.com>).
> > 
> > Signed-off-by: Loic Poulain <loic.poulain@...aro.org>
> 
> Does the existing MBIM over USB NCM also show up as a netdev?
> 
> Let's CC Dan and Bjorn on MBIM-related code, they may have opinions.
>