netdev - Re: [PATCH net-next v3 2/7] ethtool: Get link mode in use instead of speed and duplex parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKOOJTzcEPXmU=mu8PMvzkhv1CxWbL9pnmjYeYGgJHXnFW5W_g@mail.gmail.com>
Date:   Mon, 1 Feb 2021 13:59:45 -0800
From:   Edwin Peer <edwin.peer@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Danielle Ratson <danieller@...dia.com>,
        Michal Kubecek <mkubecek@...e.cz>,
        netdev <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jiri Pirko <jiri@...dia.com>, Andrew Lunn <andrew@...n.ch>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        mlxsw <mlxsw@...dia.com>, Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next v3 2/7] ethtool: Get link mode in use instead of
 speed and duplex parameters

On Mon, Feb 1, 2021 at 1:41 PM Jakub Kicinski <kuba@...nel.org> wrote:

> > > The media part is beginning to sound concerning. Every time we
> > > under-specify an interface we end up with #vendors different
> > > interpretations. And since HW is programmed by FW in most high
> > > speed devices we can't even review the right thing is done.
> >
> > Each link mode implies a very specific media type, the kernel can
> > reject illegal combinations based on the supported bitmask before
> > calling upon the driver to select it.
>
> Are you talking about validation against a driver-supplied list of
> HW-supported modes, or SFP-supported modes for a currently plugged
> in module?

Should they not be the same thing?

> The concern is around "what happens if user selected nnG-SR4 but user
> plugged in nnG-CR4". The MAC/PHY/serdes settings will be identical.

Yes, there would be multiple link modes that map to the same speed and
lane combination, but that doesn't mean you need to accept them if the
media doesn't match what's plugged in also. In the above scenario, the
supported mask should not list SR because CR is physically plugged in.
That way, the user knows what options are legal and the kernel knows
what it can reject.

Regards,
Edwin Peer

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4160 bytes)