netdev - Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8924ef5a-a3ac-1664-ca11-5f2a1f35399a@nvidia.com>
Date:   Mon, 1 Feb 2021 09:37:11 +0800
From:   Chris Mi <cmi@...dia.com>
To:     Ido Schimmel <idosch@...sch.org>, Jakub Kicinski <kuba@...nel.org>
CC:     Cong Wang <xiyou.wangcong@...il.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        <jiri@...dia.com>, Saeed Mahameed <saeedm@...dia.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC
 driver dependency

Hi Ido,

On 1/30/2021 10:42 PM, Ido Schimmel wrote:
> On Fri, Jan 29, 2021 at 12:30:09PM -0800, Jakub Kicinski wrote:
>> On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote:
>>> Instead of discussing it several days, maybe it's better to review
>>> current patch, so that we can move forward :)
>> It took you 4 revisions to post a patch which builds cleanly and now
>> you want to hasten the review? My favorite kind of submission.
>>
>> The mlxsw core + spectrum drivers are 65 times the size of psample
>> on my system. Why is the dependency a problem?
> mlxsw has been using psample for ~4 years and I don't remember seeing a
> single complaint about the dependency. I don't understand why this patch
> is needed.
Please see Saeed's comment in previous email:

"

The issue is with distros who ship modules independently.. having a
hard dependency will make it impossible for basic mlx5_core.ko users to
load the driver when psample is not installed/loaded.

I prefer to have 0 dependency on external modules in a HW driver.
"

We are working on a tc sample offload feature for mlx5_core. The distros
are likely to request us to do this. So we address it before submitting
the driver changes.

Regards,
Chris