netdev - Re: KASAN: slab-out-of-bounds Read in add_adv_patterns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 2 Feb 2021 11:10:10 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Hillf Danton <hdanton@...a.com>, Sasha Levin <sashal@...nel.org>,
        Archie Pusaka <apusaka@...omium.org>
Cc:     syzbot <syzbot+3ed6361bf59830ca9138@...kaller.appspotmail.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, Miao-chen Chou <mcchou@...omium.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...el.com>,
        syzkaller-bugs@...glegroups.com
Subject: Re: KASAN: slab-out-of-bounds Read in add_adv_patterns_monitor

Commit 36211f7fc1e7 ("Bluetooth: Pause service discovery for suspend")
seems like a bugfix as well but there is no Fixes tag there either.  The
commit message should be more clear what the effect of the bug looks
like to the user.  I like to write something like this:

[PATCH] Bluetooth: Pause service discovery for suspend

Just like MGMT_OP_START_DISCOVERY, we should reject
MGMT_OP_START_SERVICE_DISCOVERY with MGMT_STATUS_BUSY when we are paused
for suspend.  This bug was discovered by auditing the software and no
one has complained about it, but presumably it leads to a hanged process
because the cmd cannot complete.

Sometimes it's hard to know what the affect of a bug is, but since
you're working in the subsystem then you probably have a better guess
than the rest of us so even a guess is useful.

regards,
dan carpenter