netdev - Re: [PATCH net-next RESEND 2/2] net/mlx5: E-Switch, Implement devlink port function cmds to control roce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ3xEMid_wMdJ_bArXvzO1BCFJNU4s5_+555ywD3iW1DvdYztA@mail.gmail.com>
Date:   Tue, 2 Feb 2021 21:11:28 +0200
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Yishai Hadas <yishaih@...dia.com>
Cc:     Linux Netdev List <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jason Gunthorpe <jgg@...dia.com>,
        Doug Ledford <dledford@...hat.com>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Parav Pandit <parav@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH net-next RESEND 2/2] net/mlx5: E-Switch, Implement devlink
 port function cmds to control roce

On Tue, Feb 2, 2021 at 10:08 AM Yishai Hadas <yishaih@...dia.com> wrote:
> Implement devlink port function commands to enable / disable roce.
> This is used to control the roce device capabilities.

[..]

> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
> @@ -122,8 +122,9 @@ struct mlx5_vport_info {
>         int                     link_state;
>         u32                     min_rate;
>         u32                     max_rate;
> -       bool                    spoofchk;
> -       bool                    trusted;
> +       u8                      spoofchk: 1;
> +       u8                      trusted: 1;
> +       u8                      roce_enabled: 1;
>  };

This struct has attributes which have e-switch vport affiliation where
roce enable/disable
is a property of the vhca function-over-the-e-wire -- it's that we do
something specific
in the e-switching to enforce  - sounds like a problematic location to
land the bit..