netdev - Re: [PATCH v2 net-next] hv_netvsc: Copy packets sent by Hyper-V out of the receive buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Feb 2021 11:45:49 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrea Parri <parri.andrea@...il.com>
Cc:     davem@...emloft.net, linux-kernel@...r.kernel.org,
        kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        wei.liu@...nel.org, mikelley@...rosoft.com,
        linux-hyperv@...r.kernel.org, skarade@...rosoft.com,
        juvazq@...rosoft.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] hv_netvsc: Copy packets sent by Hyper-V out
 of the receive buffer

On Tue, 2 Feb 2021 09:18:43 +0100 Andrea Parri wrote:
> Hi net maintainers,
> 
> 
> On Sat, Jan 30, 2021 at 12:50:06AM +0000, patchwork-bot+netdevbpf@...nel.org wrote:
> > Hello:
> > 
> > This patch was applied to netdev/net-next.git (refs/heads/master):
> > 
> > On Tue, 26 Jan 2021 17:29:07 +0100 you wrote:  
> > > Pointers to receive-buffer packets sent by Hyper-V are used within the
> > > guest VM.  Hyper-V can send packets with erroneous values or modify
> > > packet fields after they are processed by the guest.  To defend against
> > > these scenarios, copy (sections of) the incoming packet after validating
> > > their length and offset fields in netvsc_filter_receive().  In this way,
> > > the packet can no longer be modified by the host.
> > > 
> > > [...]  
> > 
> > Here is the summary with links:
> >   - [v2,net-next] hv_netvsc: Copy packets sent by Hyper-V out of the receive buffer
> >     https://git.kernel.org/netdev/net-next/c/0ba35fe91ce3  
> 
> I'd have some fixes on top of this and I'm wondering about the process: would
> you consider fixes/patches on top of this commit now? 

Fixes for bugs present in Linus's tree?

You need to target the net tree, and give us instructions on how to
resolve the conflict which will arise from merging net into net-next.

> would you rather prefer me to squash these fixes into a v3? other?

Networking trees are immutable, and v2 was already applied. We could
do a revert, apply fix, apply v3, but we prefer to just handle the 
merge conflict.